Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow/config: enabled code freeze for 1.18 #16603

Merged
merged 1 commit into from
Mar 5, 2020
Merged

prow/config: enabled code freeze for 1.18 #16603

merged 1 commit into from
Mar 5, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 4, 2020 •
edited
Loading

/hold

This is to be merged on Thu March 5th EOD

until Tue March 17th Code Thaw

/sig release
/area release-eng
/milestone v1.18
/priority important-soon
/cc @kubernetes/release-engineering
/assign @alejandrox1

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 4, 2020
@cpanato
Copy link
Member Author

cpanato commented Mar 4, 2020

will close to avoid mistakes
/close

@k8s-ci-robot
Copy link
Contributor

@cpanato: Closed this PR.

In response to this:

will close to avoid mistakes
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Mar 5, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

@cpanato: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Mar 5, 2020

Please review @alejandrox1 @justaugustus @kubernetes/release-managers

@justaugustus
Copy link
Member

/lgtm
/approve
/hold cancel
/assign @cblecker @krzyzacy

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 5, 2020
@cpanato
Copy link
Member Author

cpanato commented Mar 5, 2020

/cc @cblecker @krzyzacy

@cblecker
Copy link
Member

cblecker commented Mar 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 61b04e0 into kubernetes:master Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

/hold

This is to be merged on Thu March 5th EOD

until Tue March 17th Code Thaw

/sig release
/area release-eng
/milestone v1.18
/priority important-soon
/cc @kubernetes/release-engineering
/assign @alejandrox1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the code-freeze-1-18 branch March 5, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@justaugustus justaugustus

@krzyzacy krzyzacy

@cblecker cblecker

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @k8s-ci-robot @justaugustus @cblecker @krzyzacy @alejandrox1